Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/docstrings dataclasses #7221

Merged
merged 6 commits into from
Feb 28, 2024
Merged

Fix/docstrings dataclasses #7221

merged 6 commits into from
Feb 28, 2024

Conversation

davidsbatista
Copy link
Contributor

@github-actions github-actions bot added 2.x Related to Haystack v2.0 type:documentation Improvements on the docs labels Feb 27, 2024
@davidsbatista davidsbatista added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Feb 27, 2024
@davidsbatista davidsbatista marked this pull request as ready for review February 27, 2024 14:01
@davidsbatista davidsbatista requested a review from a team as a code owner February 27, 2024 14:01
@davidsbatista davidsbatista requested review from julian-risch and removed request for a team February 27, 2024 14:01
@coveralls
Copy link
Collaborator

coveralls commented Feb 27, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8077933676

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 90.058%
Files with Coverage Reduction New Missed Lines %
dataclasses/document.py 3 93.81%
Totals Coverage Status
Change from base Build 8077602639: 0.0%
Covered Lines: 5281
Relevant Lines: 5864
💛 - Coveralls

shadeMe
shadeMe requested changes Feb 27, 2024
View reviewed changes
haystack/dataclasses/byte_stream.py Show resolved Hide resolved
haystack/dataclasses/document.py Outdated Show resolved Hide resolved
haystack/dataclasses/document.py Outdated Show resolved Hide resolved
@julian-risch julian-risch removed their request for review February 28, 2024 10:37
@davidsbatista davidsbatista merged commit 20ebb46 into main Feb 28, 2024
20 checks passed
@davidsbatista davidsbatista deleted the FIX/docstrings-dataclasses branch February 28, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadeMe shadeMe shadeMe approved these changes

Assignees
No one assigned
Labels
2.x Related to Haystack v2.0 ignore-for-release-notes PRs with this flag won't be included in the release notes. type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docstrings - haystack.dataclasses
3 participants
@davidsbatista @coveralls @shadeMe